fix: ensure footer width conforms to design #1404
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
timothyylim
force-pushed
the
tim/fix-footer-repsonsiveness
branch
from
e4042af to
f6d88d9
Compare
📊 Test Coverage Report
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| </a> | ||
| ))} | ||
| <div className="border-y py-10"> | ||
| <div className="max-w-5xl"> |
There was a problem hiding this comment.
| <div className="max-w-5xl"> | |
| <div className="mx-auto max-w-5xl"> |
The max-w-5xl container is missing mx-auto to center it horizontally, causing the footer content to be left-aligned instead of centered.
View Details
Analysis
Footer container missing mx-auto centering class
What fails: FooterSection component at line 49 has max-w-5xl without mx-auto, causing left-alignment instead of centering on screens wider than 1024px
How to reproduce:
# View footer on wide screen (>1024px):
pnpm dev --port 3001
# Navigate to any page and scroll to footerResult: Footer content appears left-aligned on wide screens, creating asymmetrical layout
Expected: Footer should be centered horizontally, matching established pattern used in layout.tsx (mx-auto max-w-screen-lg), chart/page.tsx (mx-auto max-w-7xl), and navbar (mx-auto max-w-screen-lg)
Reference: Tailwind CSS max-width docs confirm max-width utilities require mx-auto for centering
There was a problem hiding this comment.
This is intentional to conform to the design
dtbuchholz
left a comment
dtbuchholz
left a comment
There was a problem hiding this comment.
hm, i dont think this fixed it, but maybe @jovirecall can chime in. do we want the divs to match this? it has larger divs with the logo and text stacked.
existing code:
this PR's changes:
Fixes APP-471