Conversation
arshidkv12
commented
Aug 30, 2025
arshidkv12
commented
|
|
||
| public function getNodeTypes(): array | ||
| { | ||
| return [Assign::class, FuncCall::class]; |
There was a problem hiding this comment.
this should use StmtsAwareInterface, loop and break/skip when extra vars is used or in the middle per example at https://amitmerchant.com/everything-that-is-coming-in-php-85/
| if (! $node->expr instanceof FuncCall) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
skip $node->firstClassCallable()
There was a problem hiding this comment.
ok. vendor/bin/phpstan analyse --ansi not working.
vendor/bin/phpstan analyse --ansi
Note: Using configuration file /Users/arshid/Downloads/rector-src/phpstan.neon.
In Resolver.php line 482:
Service 'rules.0' (type of Symplify\PHPStanRules\Rules\NoDynamicNameRule): Service of type Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer
required by $callableTypeAnalyzer in NoDynamicNameRule::__construct() not found. Did you add it to configuration file?
There was a problem hiding this comment.
I can't reproduce, you may have vendor/ issue, probably remove and run composer update:
rm -rf vendor
composer update
|
Is there any blocker to move this forward? I'd like to give it a go |
|
Thank you for checking. There are no blockers on my side—please proceed. |
|
@arshidkv12 Awesome... could you rebase on latest |
Ok |
|
@arshidkv12 please use StmtsAwareInterface to loop and apply like my suggestion above #7201 (review) |
arshidkv12
force-pushed
the
php-85-Pipe
branch
from
f691ddf to
20db305
Compare
Ok |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
3 participants
