fix: EnumCaseToPascalCaseRector skips existing pascal case#7264
fix: EnumCaseToPascalCaseRector skips existing pascal case#7264samsonasik merged 2 commits intorectorphp:mainfrom
Conversation
|
|
||
| private function convertToPascalCase(string $name): string | ||
| { | ||
| if ($this->isPascalCase($name)) { |
There was a problem hiding this comment.
use existing convertToPascalCase() method, compare, if same, then skip
There was a problem hiding this comment.
That's not going to work here, the convertToPascalCase() method is not idempotent
There was a problem hiding this comment.
that strange that the check already there
rector-src/rules/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector.php
Lines 104 to 107 in 87d4427
I am on mobile, I will check when I am back to PC
There was a problem hiding this comment.
I've updated to use existing convertToPascalCase method 2a86213
samsonasik
force-pushed
the
calebdw/push-qsyqklmzmtxo
branch
from
a0d2cc9 to
2a86213
Compare
|
@calebdw this should be ok now :) |
|
Thank you @calebdw |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
2 participants
Closes rectorphp/rector#9374
Thanks!