fix: EnumCaseToPascalCaseRector bugs#7272
Conversation
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
4 times, most recently
from
2de6166 to
ec669ad
Compare
calebdw
force-pushed
the
calebdw/push-utwsxnywtlln
branch
from
ec669ad to
5a7cc94
Compare
|
|
||
| return RectorConfig::configure() | ||
| ->withRules([EnumCaseToPascalCaseRector::class]); | ||
| ->withRules([EnumCaseToPascalCaseRector::class]) |
There was a problem hiding this comment.
Like other your PR, Please don't change existing test config, use different class & config on purpose, with use of dynamic provider.
There was a problem hiding this comment.
In this case there's really no need for a separate config and test case just to test one fixture
There was a problem hiding this comment.
No, the test include existing Fixture in autoloaded, see my next comment on removed test class
There was a problem hiding this comment.
If you really insist then i can keep both, both the autoload fixture will have to be moved to a separate directory because the test cases were conflicting
There was a problem hiding this comment.
No, that on purpose :), see the whole discussion on original PRs :)
| #[DataProvider('provideData')] | ||
| public function test(string $filePath): void | ||
| { | ||
| $this->doTestFile($filePath, true); |
There was a problem hiding this comment.
This true 2nd argument is on purpose for autoload existing Fixture directory
|
Closing is you change existing config/test on purpose, please don't do that. If you have specific use case to be skipped, see the differ on original PR and it configured like this :) |
2 participants
Hello!
This fixes some more bugs in the rector:
selfwere not being renamedThanks!