[AutoImport] Optimize ClassRenamingPostRector with stop on enterNode()#7295
Merged
samsonasik merged 2 commits intomainfrom Sep 16, 2025
Merged
[AutoImport] Optimize ClassRenamingPostRector with stop on enterNode()#7295samsonasik merged 2 commits intomainfrom
samsonasik merged 2 commits intomainfrom
Conversation
Merged
Member
Author
|
PHPStan notice seems due to new PHPStan release https://github.com/phpstan/phpstan/releases/tag/2.1.26 I will fix phpstan notice in separate PR. |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar with PR:
the process already done on
beforeTraverse()We stop the traversal because all the work has already been done in the beforeTraverse() function
Using STOP_TRAVERSAL is usually dangerous as it will stop the processing of all your nodes for all visitors
but since the PostFileProcessor is using direct new NodeTraverser() and traverse() for only a single
visitor per execution, using stop traversal here is safe,
ref
rector-src/src/PostRector/Application/PostFileProcessor.php
Lines 59 to 61 in fc1e742