[Php84] Allow early return on ForeachToArrayAllRector#7316
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Sep 23, 2025
Merged
[Php84] Allow early return on ForeachToArrayAllRector#7316samsonasik merged 3 commits intorectorphp:mainfrom
samsonasik merged 3 commits intorectorphp:mainfrom
Conversation
samsonasik
approved these changes
Sep 23, 2025
Member
|
Looks good, let's give it a try, thank you @Orest-Divintari |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already a rule to convert foreach that contains a break statement with array_all. This pr is to add support to the existing rule to convert foreach with early return to array_all