[CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2#7391
[CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2#7391samsonasik merged 1 commit intomainfrom
Conversation
|
/cc @marcreichel let's another try |
| @@ -21,12 +21,12 @@ final class SimplifyRegexPatternRector extends AbstractRector | |||
| * @var array<string, string> | |||
| */ | |||
| private const COMPLEX_PATTERN_TO_SIMPLE = [ | |||
There was a problem hiding this comment.
Could you add note about the scoper issue? So we at least know "why" , since there is no test fixture to verify
There was a problem hiding this comment.
The fixture is exists, see https://github.com/rectorphp/rector-src/pull/7390/files#diff-50a42149759f087eb3dce4cbe895b8f759b6e1b26013eb262d8a088c39706e03
It just issue with php-scoper.
I will look if it can simply be handled by double quote.
There was a problem hiding this comment.
Properly resolved with double quoted:
on dev-main rectorphp/rector@d61e2b7
Tested locally, working ok.
I will add the note comment.
There was a problem hiding this comment.
I created PR to add comment about it
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
2 participants
Ref rectorphp/rector#9395