[dead-code] Add RemoveUnusedClosureVariableUseRector

[TomasVotruba]

Reported by PHPStan, now fixed by Rector 👍

class Fixture
{
    public function run($value)
    {
-        return function () use ($value) {
+        return function () {
            return 'value';
        };
    }
}

[samsonasik]

this should verify compact use as well, better use ExprUsedInNodeAnalyzer for it, I will create new PR for it.

[samsonasik]

I created new PR to skip used via compact()

• [DeadCode] Skip used via compact() on RemoveUnusedClosureVariableUseRector #7431

[samsonasik]

this should under Closure namespace:

-namespace Rector\DeadCode\Rector\Concat;
+namespace Rector\DeadCode\Rector\Closure;

I will create new PR for it.

[samsonasik]

I create new PR to fix namespace to Closure

• [DeadCode] Fix RemoveUnusedClosureVariableUseRector namespace to under Closure namespace #7432

[samsonasik]

this is not needed, already covered at NodeAttributeReIndexer, see

rector-src/src/Application/NodeAttributeReIndexer.php

Lines 69 to 71 in d948383

	if ($node instanceof Closure) {
	$node->uses = array_values($node->uses);
	}

[samsonasik]

I created new PR for it:

• [DeadCode] Clean up unnecessary reindex use on RemoveUnusedClosureVariableUseRector #7433

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.