Skip to content

Different logic: verify equal before substr on ClassLikeNameClassNameImportSkipVoter#7450

Merged
samsonasik merged 10 commits intomainfrom
different-logic-substr
Oct 8, 2025
Merged

Different logic: verify equal before substr on ClassLikeNameClassNameImportSkipVoter#7450
samsonasik merged 10 commits intomainfrom
different-logic-substr

Conversation

@samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

I will add test to support short class name import on cover with existing class name.

https://getrector.com/demo/8ed4f981-10db-4276-8c8a-edbcd3ff26c5

@samsonasik
Copy link
Member Author

I added test fixture for short name use in class name 11e2c3a

@samsonasik
Copy link
Member Author

samsonasik commented Oct 8, 2025

on no namespaced class name, short name conflict check is needed as make error on other tests, so I just skipped as current behaviour for now, updated the test.

@samsonasik
Copy link
Member Author

@TomasVotruba Let's merge so @JoshuaEstes and @simonschaufi can test :)

@samsonasik samsonasik merged commit 7ccb174 into main Oct 8, 2025
50 checks passed
@samsonasik samsonasik deleted the different-logic-substr branch October 8, 2025 07:53
@samsonasik
Copy link
Member Author

samsonasik commented Oct 8, 2025

@JoshuaEstes and @simonschaufi could you verify latest dev-main

composer config minimum-stability dev
composer config prefer-stable true
composer update rector/rector:dev-main

and verify is patch not cause regression? Thank you.

@TomasVotruba
Copy link
Member

👍

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants