[type-declaration] Add AddParamTypeFromStrictMethodCallPassRector#7488
Closed
TomasVotruba wants to merge 3 commits intomainfrom
Closed
[type-declaration] Add AddParamTypeFromStrictMethodCallPassRector#7488TomasVotruba wants to merge 3 commits intomainfrom
TomasVotruba wants to merge 3 commits intomainfrom
Conversation
samsonasik
reviewed
Oct 13, 2025
Comment on lines
+41
to
+51
| final class SomeClass | ||
| { | ||
| public function run($value) | ||
| { | ||
| $this->resolve($value); | ||
| } | ||
|
|
||
| private function resolve(int $value) | ||
| { | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
@TomasVotruba there is already rule ParamTypeByMethodCallTypeRector for it, see
https://getrector.com/demo/e925c962-1957-42dc-8464-c943e7c2850b
Member
Author
There was a problem hiding this comment.
Thanks 👍 I knew we had some similar rule :D . It missed an edge case, I'll check why.
Member
Author
There was a problem hiding this comment.
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.