Improve parent call fixture in Php4ConstructorRector not to use KEY constant#7642
Merged
TomasVotruba merged 4 commits intomainfrom Nov 20, 2025
Merged
Improve parent call fixture in Php4ConstructorRector not to use KEY constant#7642TomasVotruba merged 4 commits intomainfrom
TomasVotruba merged 4 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-keys
branch
from
88ae2d4 to
bba767d
Compare
samsonasik
reviewed
Nov 20, 2025
rules-tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/method_call_parent.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
Nov 20, 2025
...tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/parent_constructor_call.php.inc
Outdated
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-keys
branch
from
ab48181 to
b1d9aa3
Compare
samsonasik
reviewed
Nov 20, 2025
...tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Fixture/parent_constructor_call.php.inc
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-keys
branch
from
9eed7bc to
651eed7
Compare
TomasVotruba
force-pushed
the
tv-keys
branch
from
651eed7 to
256004a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constant should never existsed, as we always use current keys by foreaching by convention as more reliable than attributes.
KISS :)