[fix] Fix named arg broken printer on array_map #7715
Merged
TomasVotruba merged 3 commits intomainfrom Dec 4, 2025
Merged
Conversation
…s changed args on print
4438b12 to
ef3aa32
Compare
d8d7732 to
6b94299
Compare
samsonasik
requested changes
Dec 4, 2025
Member
There was a problem hiding this comment.
To support cross-platform compatibility( eg on windows) it can be changed to:
// Normalize line endings for cross-platform compatibility
$this->assertSame(
str_replace("\r\n", "\n", $expectedContents),
str_replace("\r\n", "\n", $printerContents)
);in PHPStanPrinterTest.php
I can help fix it if you need :)
022df18 to
cd20677
Compare
cd20677 to
ac0e705
Compare
Member
|
@TomasVotruba phpstan 2.1.33 just released https://github.com/phpstan/phpstan/releases/tag/2.1.33 I think we can give phpstan 2.1.33 a try, include the |
Member
|
I created PR: for it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary workaround to allow printer work on named args of
array_map()Follow up to #7676
Closes rectorphp/rector#9492