fix(RemoveParentCallWithoutParentRector): skip cases when class reflection is not found

[calebdw]

Hello!

This rule is removing the parent::__construct() calls when it shouldn't. After some digging I found that the following returns true when the class reflection can't be found, instead of assuming that it has no parents we should just skip:

 return $this->classMethodManipulator->hasParentMethodOrInterfaceMethod($class, $calledMethodName);

Thanks!

[samsonasik]

Could you add fixture file for it? Thank you.

[calebdw]

I tried, but I couldn't replicate in the fixture. It has to do with the reflection provider not being able to find the class

[samsonasik]

That's strange as class is a node the rule visited, that the ClassReflection exists. I assume you have duplicated class name so phpstan can't locate which one which.

[calebdw]

I think it's because I run rector on our tests, but I exclude the tests from phpstan because I don't care about all the warnings. This is the first time I've had any issues

[samsonasik]

in that case, I guess you can add autoloadPaths it via withAutoloadPaths

https://getrector.com/documentation/static-reflection-and-autoload

[calebdw]

Hmm, doesn't look like that worked

[samsonasik]

rector config can set its own phpstan, see example

https://github.com/codeigniter4/shield/blob/d07c0f9442dd0712b3fa39bfba677838ff1b8e26/rector.php#L92-L97

[calebdw]

Hmm, looks like I needed to split excludePaths into a combination of analyse and analyseAndScan:

https://phpstan.org/config-reference#analysed-files