Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\Php85\Rector\FuncCall\OrdSingleByteRector\Fixture;

final class SkipSingleLiteralInt
{
public function run()
{
return ord(0);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\Php85\Rector\FuncCall\OrdSingleByteRector\Fixture;

final class SkipSingleLiteralString
{
public function run()
{
return ord('0');
}
}
8 changes: 8 additions & 0 deletions rules/Php85/Rector/FuncCall/OrdSingleByteRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ public function refactor(Node $node): ?Node
$value = $this->valueResolver->getValue($argExpr);
$isInt = is_int($value);

if ($argExpr instanceof String_ && strlen($argExpr->value) === 1){
return null;
}

if ($argExpr instanceof Int_ && strlen((string) $argExpr->value) === 1){
return null;
}

if (! $argExpr instanceof Int_) {
return $this->refactorStringType($argExpr, $isInt, $args, $node);
}
Expand Down
Loading