Skip to content

[CodeQuality] Skip first class callable on ParameterBagTypedGetMethodCallRector #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Sep 1, 2025
Merged

[CodeQuality] Skip first class callable on ParameterBagTypedGetMethodCallRector #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
609c221
[CodeQuality] Skip first class callable on ParameterBagTypedGetMethod…
samsonasik Sep 1, 2025
0889e46
[CodeQuality] Skip first class callable on ParameterBagTypedGetMethod…
samsonasik Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...MethodCall/ParameterBagTypedGetMethodCallRector/Fixture/skip_first_class_callable.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\Symfony\Tests\CodeQuality\Rector\MethodCall\ParameterBagTypedGetMethodCallRector\Fixture;

use Symfony\Component\HttpFoundation\Request;

final class SkipFirstClassCallable
{
public function run(Request $request)
{
$debug = (bool) $request->query->get(...);
}
}
4 changes: 4 additions & 0 deletions rules/CodeQuality/Rector/MethodCall/ParameterBagTypedGetMethodCallRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ public function refactor(Node $node): ?Node

private function refactorMethodCall(MethodCall $methodCall): ?MethodCall
{
if ($methodCall->isFirstClassCallable()) {
return null;
}

// default value must be defined
if (count($methodCall->getArgs()) !== 2) {
return null;
Expand Down