feat(x2a): Adding ModulePage with details, former phase retrigger and logs by eloycoto · Pull Request #2327 · redhat-developer/rhdh-plugins

eloycoto · 2026-02-13T15:40:07Z

A rebase form #2319

rhdh-gh-app · 2026-02-13T15:40:30Z

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

/home/runner/work/rhdh-plugins/rhdh-plugins/workspaces/x2a/.changeset/clean-books-wish.md: @red-hat-developer-hub/backstage-plugin-x2a-backend, @red-hat-developer-hub/backstage-plugin-x2a-common

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@red-hat-developer-hub/backstage-plugin-x2a	workspaces/x2a/plugins/x2a	patch	`v1.0.0`

elai-shalev

Some comments

elai-shalev · 2026-02-15T09:00:24Z

workspaces/x2a/plugins/x2a/src/components/ProjectList/EmptyProjectList.tsx

+  // Do not merge
+  useSeedTestData();
+


this needs to be removed before merging

elai-shalev · 2026-02-15T09:00:48Z

workspaces/x2a/plugins/x2a/src/components/NewProjectPage.tsx.toBeDeleted

+/*
+ * Copyright Red Hat, Inc.
+ *


this file should not be merged

elai-shalev · 2026-02-15T09:01:00Z

workspaces/x2a/plugins/x2a/src/components/WizardActions.tsx.toBeDeleted

+/*
+ * Copyright Red Hat, Inc.
+ *


this file should not be merged

elai-shalev · 2026-02-15T09:15:28Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/PhasesCard.tsx

+    <Grid container direction="row" spacing={3}>
+      {phase && (
+        <RunAction
+          instructions={t('modulePage.phases.reanalyzeInstructions')}
+          actionText={t('modulePage.phases.rerunAnalyze')}
+        />
+      )}
+      {!phase && (
+        <RunAction
+          instructions={t('modulePage.phases.analyzeInstructions')}
+          actionText={t('modulePage.phases.runAnalyze')}
+        />
+      )}
+      {/* TODO: Button for canceling the current job execution */}


this has analyze hardcoded?

Only analyze in taken care of, both here and in the Button grid on L77.
I think this PR would need all three possibilities introduced (analyze, migrate, publish)

elai-shalev · 2026-02-15T09:16:07Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/PhasesCard.tsx

+      <Grid item xs={12}>
+        <Button variant="primary">{actionText}</Button>
+      </Grid>
+      <Grid item xs={12}>
+        <Typography>{instructions}</Typography>
+      </Grid>
+    </>


this button has no OnClick method, it does nothing

elai-shalev · 2026-02-15T09:21:49Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/ArtifactsCard.tsx

+  return (
+    <Link
+      to={buildArtifactUrl(artifact.value, '')}
+      target="_blank"
+      rel="noopener noreferrer"
+      key={artifact.id}
+    >
+      {humanizeArtifactType(t, artifact.type)}
+    </Link>
+  );


This seems like it can create a broken link if the artifact value is a relative path

elai-shalev · 2026-02-15T09:22:40Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/ModulePageBreadcrumb.tsx

+    >
+      <Link to="/">{t('page.title')}</Link>
+      <Typography>{t('modulePage.title')}</Typography>
+      <Typography>Breadcrumbs</Typography>


this is leftover? (leftover bread)

elai-shalev · 2026-02-15T09:23:07Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/ModulePageBreadcrumb.tsx

+      separator=">"
+      className={classes.breadcrumbs}
+    >
+      <Link to="/">{t('page.title')}</Link>


should be /x2a/api?

elai-shalev · 2026-02-15T09:24:46Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/PhasesCard.tsx

+      <Grid item xs={3}>
+        <ItemField
+          label={t('modulePage.phases.startedAt')}
+          value={humanizeDate(phase?.startedAt || empty)}


when phase?.startedAt is falsy, empty is the translation of 'module.phases.none' (e.g., "None").
new Date("None") returns Invalid Date, which toLocaleString renders as the string "Invalid Date". The callers in ModuleTable.tsx guard against this by checking if (!lastJob) before calling humanizeDate, but PhasesCard does not — it always calls through. The fallback should be handled before calling humanizeDate.

… logs Signed-off-by: Marek Libra <marek.libra@gmail.com>

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>

elai-shalev · 2026-02-16T14:56:05Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/ArtifactsCard.tsx

+  }
+  return (
+    <Link
+      to={buildArtifactUrl(artifact.value, targetRepoUrl)}


needs to add target repo branch after 2332 was merged

elai-shalev · 2026-02-16T14:59:05Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/PhasesCard.tsx

+    <Grid container direction="row" spacing={3}>
+      {phase && (
+        <RunAction
+          instructions={t('modulePage.phases.reanalyzeInstructions')}
+          actionText={t('modulePage.phases.rerunAnalyze')}
+        />
+      )}
+      {!phase && (
+        <RunAction
+          instructions={t('modulePage.phases.analyzeInstructions')}
+          actionText={t('modulePage.phases.runAnalyze')}
+        />
+      )}
+      {/* TODO: Button for canceling the current job execution */}


Only analyze in taken care of, both here and in the Button grid on L77.
I think this PR would need all three possibilities introduced (analyze, migrate, publish)

elai-shalev · 2026-02-16T15:01:28Z

workspaces/x2a/plugins/x2a/src/components/ModulePage/ModulePageBreadcrumb.tsx

+    <Breadcrumbs
+      aria-label="breadcrumb"
+      separator=">"
+      className={classes.breadcrumbs}
+    >
+      <Link to="/x2a/api">{t('page.title')}</Link>
+      <Typography>{t('modulePage.title')}</Typography>
+    </Breadcrumbs>
+  );
+};


I think we might need to dynamically generate the links here rather than hardcode /x2a/api. I know I said otherwise in a prior PR, I'm not sure how the breadcrumbs are used here
So maybe at least let's add a TODO: revise here so we take another look at it

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>

sonarqubecloud · 2026-02-16T15:35:46Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

openshift-ci bot added the do-not-merge/work-in-progress label Feb 13, 2026

eloycoto force-pushed the MarekPR2319 branch 3 times, most recently from fc09a3b to 00d5523 Compare February 13, 2026 17:36

eloycoto marked this pull request as ready for review February 13, 2026 17:41

eloycoto requested review from elai-shalev and mareklibra as code owners February 13, 2026 17:41

openshift-ci bot removed the do-not-merge/work-in-progress label Feb 13, 2026

elai-shalev reviewed Feb 15, 2026

View reviewed changes

eloycoto force-pushed the MarekPR2319 branch 2 times, most recently from 99fef1f to 89cf58d Compare February 16, 2026 14:38

mareklibra and others added 3 commits February 16, 2026 15:49

feat(x2a): Adding ModulePage with details, former phase retrigger and…

cf59e8d

… logs Signed-off-by: Marek Libra <marek.libra@gmail.com>

fix(x2a): added module page CI fixes

54909f5

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>

fix(x2a): changes based on PR reviews

146a612

eloycoto force-pushed the MarekPR2319 branch from 89cf58d to f2f6a1e Compare February 16, 2026 14:51

elai-shalev reviewed Feb 16, 2026

View reviewed changes

feat(x2a): multiple fixes on modulePage

ff357a7

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>

eloycoto force-pushed the MarekPR2319 branch from f2f6a1e to ff357a7 Compare February 16, 2026 15:09

eloycoto and others added 3 commits February 16, 2026 16:14

fix(x2a): cleaning the report-api

31bdcd6

feat(x2a): fix Elai comments

28659bd

Merge branch 'main' into MarekPR2319

471b2e0

elai-shalev approved these changes Feb 16, 2026

View reviewed changes

elai-shalev merged commit 4465f5c into redhat-developer:main Feb 16, 2026
9 checks passed

Comments

Conversation

eloycoto commented Feb 13, 2026

Uh oh!

rhdh-gh-app bot commented Feb 13, 2026

Unexpected Changesets

Changed Packages

Uh oh!

elai-shalev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 16, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants