FLPATH-3235 | [Bug] Cost management sidebar nav visible to users without cost management RBAC permissions#2335
FLPATH-3235 | [Bug] Cost management sidebar nav visible to users without cost management RBAC permissions#2335asmasarw wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
…out cost management RBAC permissions
edab03c to
3749c7e
Compare
|
PreetiW
left a comment
There was a problem hiding this comment.
I have asked a UX question around this PR here https://redhat-internal.slack.com/archives/C06JYPH9RPA/p1771334321817169 , once we get input will move forward with the review based on the same. 🙌🏻
PreetiW
left a comment
There was a problem hiding this comment.
@asmasarw In this PR we are doing Multiple calls to useResourceOptimizationAccess() (lines 29, 53, 96) cause 6 redundant API requests. Wrap Router with Context Provider to call once and share results. What do you think?
rest of the code looks good to me 👍🏻



FLPATH-3235 | [Bug] Cost management sidebar nav visible to users without cost management RBAC permissions
Added Cost Management Guard that performs the following:
Attached All Cases (Has Full Access, Access Only for OpenShift, Access for Only Optimizations, No Access at all)
NO ACCESS FOR BOTH ROUTES
ACCESS ONLY FOR OPENSHIFT
ACCESS ONLY FOR OPTIMIZATIONS
ACCESS FOR ALL