-
Notifications
You must be signed in to change notification settings - Fork 94
FLPATH-2749 | Refactor the Plugin code based on new structure to cost-management #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "packageRules": [ | ||
| { | ||
| "description": "all Cost Management minor updates", | ||
| "matchFileNames": ["workspaces/cost-management/**"], | ||
| "extends": [ | ||
| "github>redhat-developer/rhdh-plugins//.github/renovate-presets/base/rhdh-minor-presets(Cost Management)" | ||
| ], | ||
| "addLabels": ["team/cost-management", "cost-management"] | ||
| }, | ||
| { | ||
| "description": "all Cost Management patch updates", | ||
| "matchFileNames": ["workspaces/cost-management/**"], | ||
| "extends": [ | ||
| "github>redhat-developer/rhdh-plugins//.github/renovate-presets/base/rhdh-patch-presets(Cost Management)" | ||
| ], | ||
| "addLabels": ["team/cost-management", "cost-management"] | ||
| }, | ||
| { | ||
| "description": "all Cost Management dev dependency updates", | ||
| "matchFileNames": ["workspaces/cost-management/**"], | ||
| "extends": [ | ||
| "github>redhat-developer/rhdh-plugins//.github/renovate-presets/base/rhdh-devdependency-presets(Cost Management)" | ||
| ], | ||
| "addLabels": ["team/cost-management", "cost-management"] | ||
| } | ||
| ] | ||
| } |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Resource Optimization Common | ||
|
|
||
| Shared isomorphic code for the redhat-resource-optimization plugin. | ||
|
|
||
| ## Generating the API client | ||
|
|
||
| The client is generated from the Optimizations (ROS) OpenAPI spec. The spec's `info.title` is set to `redhat-resource-optimization` (see [Generating API Clients](https://backstage.io/docs/openapi/generate-client/)). Run from the common package: | ||
|
|
||
| ```sh | ||
| yarn generate-client | ||
| ``` | ||
|
|
||
| If a Cost Management reports API OpenAPI spec becomes available, the script in `scripts/generate_client.mjs` can be extended to fetch or merge it. | ||
|
|
||
| ## Links | ||
|
|
||
| - [Resource Optimization front-end plugin](../redhat-resource-optimization/README.md) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,7 +120,7 @@ export const getLegendData = ( | |
|
|
||
| const result: any = []; | ||
|
|
||
| series.map((s, index) => { | ||
| series.forEach((s, index) => { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is that?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a Sonar Qube Issue fixed here. |
||
| if (s.legendItem) { | ||
| const data = { | ||
| childName: s.childName, | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I commented before, previously this was used without prefix, and after the refactor you introduced a prefix, is thsi expect? is this the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the name is fine, but the nested values were incorrect.
Reverted.