feat: add orion visualization links for successful job runs#106
Merged
vishnuchalla merged 1 commit intoMay 13, 2026
Merged
Conversation
Signed-off-by: Nabeel Mohd <mmnabeel317@gmail.com>
Collaborator
Collaborator
|
/lgtm |
Collaborator
|
looks neat. great job on these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Orion visualization links were previously only posted for changepoint/orion failure jobs. This PR extends that behavior to also post visualization links as threaded replies on successful job notifications, giving the team quick access to performance trend charts regardless of job outcome.
Changes
bugzooka/analysis/log_summarizer.py_construct_deferred_viz_urls→construct_all_orion_viz_urlsto expose it as a public function for reuse outside the failure pipeline.construct_visualization_urlto use the new name.bugzooka/integrations/slack_fetcher.pyconstruct_all_orion_viz_urlsto imports._process_message(): messages matching"ended with" + "success"are routed to the new handler, placed after the summarize trigger and before the failure gate._handle_success_viz()method that:construct_all_orion_viz_urls.:white_check_mark:links per test if artifacts are found.tests/test_slack_fetcher.pytest_success_processing(which asserted zero messages) with two new tests:test_success_processing_with_viz— mocks viz URLs present, asserts 1 message posted with correct content.test_success_processing_no_viz— mocks viz URLs asNone, asserts 0 messages posted.What is NOT changed
Test plan
SLACK_BOT_TOKEN=xoxb-test SLACK_APP_TOKEN=xapp-test make test)ruff checkpasses with no errorsconstruct_all_orion_viz_urlsreturns correct GCS URLs for a real Prow job/cc @mohit-sheth