CPT: results.csv update and metrics logging#57
Merged
Conversation
For both auto & throughput mode: Change colons to commas Replace header creation with Dave's function (includes start and end times for OpenSearch) Rename final results.csv to results_iozone.csv
...to make columns line up ahead of adding start and end times
Doing it on a per-filesystem basis since 1) getting more granular would require more complex surgery on the data reduction and 2) the timestamps aren't particularly useful because of how iozone runs; they're only there to make OpenSearch happy
For auto mode, add logging of final results to pcp archive Add iozone-specific pcp and openmetrics configs Also minor cleanup
dvalinrh
requested changes
Mar 10, 2026
| pcp_frewrite=`echo ${resline} | cut -d , -f 14` | ||
| pcp_fread=`echo ${resline} | cut -d , -f 15` | ||
| pcp_freread=`echo ${resline} | cut -d , -f 16` | ||
| fi |
...because github did a number on spaces and tab stops
dvalinrh
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This provides enabling features for CPT, to wit:
-- updates results.csv to use commas instead of colons and adds timestamps
-- logs config "knobs" and results to PCP arhive
Includes both auto and throughput mode updates
Note: Results validation and misc cleanup will be a later PR; this one's already a bit cumbersome
Before/After Comparison
Old format of results files becomes new format of results files
Metrics are no9w logged
Clerical Stuff
This closes #56
Relates to JIRA: RPOPC-860
Supporting cast:
results_iozone_csv_tput.txt
results_iozone_csv_auto.txt
ioz_auto_om.txt
ioz_tput_om.txt
ioz_auto_pcpdiskdev.txt