Conversation
about unit change
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoStandardize time values to nanoseconds for accurate results
WalkthroughsDescription• Convert all time values to nanoseconds for consistent unit handling • Eliminate unit conversion errors by standardizing on nanosecond output • Skip "Try to rerun" messages to prevent data corruption • Simplify PCP metric conversion by removing redundant unit conversions Diagramflowchart LR
A["Parse test results<br/>with various units"] -- "Convert to<br/>nanoseconds" --> B["Accumulate values<br/>in nanoseconds"]
B -- "Calculate average<br/>in nanoseconds" --> C["Output CSV<br/>with ns unit"]
C -- "Convert to seconds<br/>for PCP" --> D["Send to PCP<br/>metric system"]
File Changes1. pyperf/pyperf_run
|
Code Review by Qodo
1.
|
|
This relates to RPOPC-947 |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Please give a new CSV with the latest changes. Fix commit messages so it's documented in the commit history that we are using seconds instead of nanoseconds |
|
Latest csv |
2 participants
There is an issue with the time units. The unit may switch from run to run of each subtest (if we are at the boundary). This will cause erroneous reporting of data and averaging. To remedy this, convert the time run for each subtest pass to be nanoseconds.
Description
Fixes the results so they are always in ns.
Before/After Comparison
Before: We could get a mix of units when summing up results. Last unit is what gets reported
After: Results are now reported in ns.
Clerical Stuff
This closes #71
Relates to JIRA: RPOPC-947
Testing:
Ran and verified the output is what we expect.
csv portion
Test,Avg,Unit,Start_Date,End_Date
2to3,247483333,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_generators,316516666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_none,393866666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_cpu_io_mixed,613350000,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_cpu_io_mixed_tg,618100000,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager,98886666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_cpu_io_mixed,365216666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_cpu_io_mixed_tg,521300000,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_io,1070666666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_io_tg,1036133333,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_memoization,234616666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_memoization_tg,378816666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_eager_tg,270533333,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_io,942900000,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z
async_tree_io_tg,954366666,ns,2026-04-23T14:45:49Z,2026-04-23T15:38:33Z