Add in test verification, as we well as fix test_tools#61
Merged
Conversation
|
This relates to RPOPC-826 |
kdvalin
requested changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds verification of streams results
Before/After Comparison
Before: Test results were not verified
After: Test results are now verified.
Clerical Stuff
This closes #60
Relates to JIRA: RPOPC-826
Testing
Command executed:
/home/ec2-user/workloads/streams-wrapper-2.2/streams/streams_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m7i.xlarge" --sysname "m7i.xlarge" --sys_type aws --use_pcp --iterations 1
Successful run
CsV File
Array_sizes,107520k,215040k,430080k,Start_Date,End_Date
Copy,45930,45716,45710,2026-02-10T17:06:43Z,2026-02-10T17:08:54Z
Scale,29868,29812,29936,2026-02-10T17:06:43Z,2026-02-10T17:08:54Z
Add,30269,30031,30132,2026-02-10T17:06:43Z,2026-02-10T17:08:54Z
Triad,30050,29864,29927,2026-02-10T17:06:43Z,2026-02-10T17:08:54Z
echo $?
0
Induced error
./run_stream --cache_cap_size 0 --iterations 1 --cache_start_size 1 --optimize_lvl 3 --cache_multiply 2 --numb_sizes 4 --thread_multiply 2 --results_dir results_streams_virtual-guest_20260210175218 --host m7i.xlarge --size_list 0 --top_dir /home/ec2-user --pcp /tmp/pcp_2026.02.10-17.52.18
./run_stream --cache_cap_size 0 --iterations 1 --cache_start_size 1 --optimize_lvl 2 --cache_multiply 2 --numb_sizes 4 --thread_multiply 2 --results_dir results_streams_virtual-guest_20260210175218 --host m7i.xlarge --size_list 0 --top_dir /home/ec2-user --pcp /tmp/pcp_2026.02.10-17.52.18
Could not verify schema, see below for details
1 validation error for list[Streams_Results]
0.Triad
Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='T28935', input_type=str]
For further information visit https://errors.pydantic.dev/2.12/v/int_parsing
Could not verify schema, see below for details
1 validation error for list[Streams_Results]
0.Triad
Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='T30167', input_type=str]
For further information visit https://errors.pydantic.dev/2.12/v/int_parsing
updating: results_streams_virtual-guest.tar (deflated 87%)
[root@ip-170-0-17-19 ec2-user]# echo $?
1