tests/beakerlib: Add new test which covers build-in functions.#591
Open
RHEmployee wants to merge 1 commit intoredhat-performance:masterfrom
Open
tests/beakerlib: Add new test which covers build-in functions.#591RHEmployee wants to merge 1 commit intoredhat-performance:masterfrom
RHEmployee wants to merge 1 commit intoredhat-performance:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,16 @@ | |||
| import base | |||
| from tuned.utils.commands import commands | |||
Check notice
Code scanning / CodeQL
Unused import
| @@ -0,0 +1,16 @@ | |||
| from . import base | |||
| from tuned.utils.commands import commands | |||
Check notice
Code scanning / CodeQL
Unused import
| super(self.__class__, self).__init__("testfunc", 2) | ||
|
|
||
| def execute(self, args): | ||
| f = open(str(args[0]),'w') |
Check warning
Code scanning / CodeQL
File is not always closed
| super(self.__class__, self).__init__("testfunc", 2) | ||
|
|
||
| def execute(self, args): | ||
| f = open(str(args[0]),'w') |
Check warning
Code scanning / CodeQL
File is not always closed
Contributor
|
@RHEmployee could you fix the CodeQL found issues and could you fix the test? |
Contributor
Author
|
Rhel7 or centos7 is not supported by this test which is reflected in provided metadata. One issue is preset: wrong detection of centos. |
RHEmployee
force-pushed
the
add-test-built-in-functions
branch
from
e5ddeb1 to
a3199e6
Compare
RHEmployee
force-pushed
the
add-test-built-in-functions
branch
from
a3199e6 to
eb5681e
Compare
Contributor
|
/test |
Contributor
|
/packit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.