Fix command queue corruption on encoding failures

src/main/java/io/lettuce/core/RedisPublisher.java

@@ -59,6 +59,7 @@
  * are emitted as they are decoded. Otherwise, results are processed at command completion.
  *
  * @author Mark Paluch
+ * @author Tihomir Mateev
  * @since 5.0
  */
 class RedisPublisher<K, V, T> implements Publisher<T> {
@@ -293,7 +294,7 @@ public void onNext(T t) {
                     try {
                         DEMAND.decrementAndGet(this);
                         this.subscriber.onNext(t);
-                    } catch (Exception e) {
+                    } catch (Throwable e) {
                         onError(e);
                     }
                     return;
@@ -544,7 +545,7 @@ void request(RedisSubscription<?> subscription, long n) {
 
                         try {
                             subscription.checkCommandDispatch();
-                        } catch (Exception ex) {
+                        } catch (Throwable ex) {
                             subscription.onError(ex);
                         }
                         subscription.checkOnDataAvailable();
@@ -575,7 +576,7 @@ void onDataAvailable(RedisSubscription<?> subscription) {
                             return;
                         }
                     } while (subscription.hasDemand());
-                } catch (Exception e) {
+                } catch (Throwable e) {
                     subscription.onError(e);
                 }
             }

src/main/java/io/lettuce/core/protocol/CommandEncoder.java

@@ -76,10 +76,12 @@ private void encode(ChannelHandlerContext ctx, ByteBuf out, RedisCommand<?, ?, ?
         try {
             out.markWriterIndex();
             command.encode(out);
-        } catch (RuntimeException e) {
-            out.resetWriterIndex();
-            command.completeExceptionally(new EncoderException(
-                    "Cannot encode command. Please close the connection as the connection state may be out of sync.", e));
+        } catch (Throwable e) {
+            ctx.close();
+            logger.error("{} Cannot encode command. Closing the connection as the connection state may be out of sync.",
+                    logPrefix(ctx.channel()), e);
+            throw new EncoderException(
+                    "Cannot encode command. Closing the connection as the connection state may be out of sync.", e);
         }
 
         if (debugEnabled) {

src/main/java/io/lettuce/core/protocol/CommandHandler.java

@@ -76,6 +76,7 @@
  * @author Daniel Albuquerque
  * @author Gavin Cook
  * @author Anuraag Agrawal
+ * @author Tihomir Mateev
  */
 public class CommandHandler extends ChannelDuplexHandler implements HasQueuedCommands {
 
@@ -646,8 +647,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf buffer) throws Interrup
                         return;
                     }
 
-                } catch (Exception e) {
-
+                } catch (Throwable e) {
                     ctx.close();
                     throw e;
                 }
@@ -672,8 +672,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf buffer) throws Interrup
                         decodeBufferPolicy.afterPartialDecode(buffer);
                         return;
                     }
-                } catch (Exception e) {
-
+                } catch (Throwable e) {
                     ctx.close();
                     throw e;
                 }
@@ -691,8 +690,9 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf buffer) throws Interrup
                                 logger.debug("{} Completing command {}", logPrefix(), command);
                             }
                             complete(command);
-                        } catch (Exception e) {
+                        } catch (Throwable e) {
                             logger.warn("{} Unexpected exception during request: {}", logPrefix, e.toString(), e);
+                            command.completeExceptionally(e);
                         }
                     }
                 }