Expose max_distance as an optional setting in multi vector queries by justin-cechmanek · Pull Request #478 · redis/redis-vl-python

justin-cechmanek · 2026-02-19T22:35:46Z

No description provided.

jit-ci · 2026-02-19T22:35:57Z

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Copilot

Pull request overview

This pull request adds support for configurable max_distance parameters in multi-vector queries, allowing users to specify different distance thresholds for each vector field. Previously, the max_distance was hardcoded to 2.0.

Changes:

Added max_distance field to the Vector class with default value of 2.0 and validation range [0.0, 2.0]
Modified MultiVectorQuery to use per-vector max_distance values in VECTOR_RANGE queries
Changed query operator from | (OR) to AND for combining multiple vector range queries
Added comprehensive unit and integration tests for the new max_distance functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
redisvl/query/aggregate.py	Added max_distance field to Vector class with validation; updated query building to use per-vector max_distance values; changed operator from OR to AND
tests/unit/test_aggregation_types.py	Added test coverage for max_distance parameter including validation tests and query string generation tests
tests/integration/test_aggregation.py	Added parameterized integration test to verify max_distance filtering behavior with various distance combinations
tests/integration/test_search_index.py	Minor formatting: added blank line for code style consistency
tests/integration/test_redis_cluster_support.py	Minor formatting: added blank lines for code style consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

redisvl/query/aggregate.py

tests/integration/test_aggregation.py

tests/unit/test_aggregation_types.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T23:05:04Z

redisvl/query/aggregate.py

+        if not isinstance(max_distance, (float, int)):
+            raise ValueError("max_distance must be a value between 0.0 and 2.0")


The type check isinstance(max_distance, (float, int)) on line 43 is redundant because Pydantic's field validation already ensures the field is of type float. Additionally, this check will always pass since the field is declared as max_distance: float = 2.0. The more important validation is the range check on line 45, which should remain.

Suggested change

if not isinstance(max_distance, (float, int)):

raise ValueError("max_distance must be a value between 0.0 and 2.0")

tests/integration/test_aggregation.py

nkanu17

lgtm!

redisvl/query/aggregate.py

vishal-bala

LGTM! Just one note where you can use built-in Pydantic validation instead of custom

redisvl/query/aggregate.py

Co-authored-by: Vishal Bala <vishal-bala@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

redisvl/query/aggregate.py

Copilot · 2026-02-21T01:20:16Z

redisvl/query/aggregate.py

+    @field_validator("max_distance")
+    @classmethod
+    def validate_max_distance(cls, max_distance: float) -> float:
+        if not isinstance(max_distance, (float, int)):
+            raise ValueError("max_distance must be a value between 0.0 and 2.0")
+        if max_distance < 0.0 or max_distance > 2.0:
+            raise ValueError("max_distance must be a value between 0.0 and 2.0")
+        return max_distance


validate_max_distance currently rejects infinities but will still allow NaN (all comparisons to NaN are false, so it passes through). NaN would produce an invalid VECTOR_RANGE radius in the query string. Consider explicitly rejecting non-finite values (and also disallowing bool, since it’s an int subclass).

Copilot · 2026-02-21T01:20:16Z

redisvl/query/aggregate.py

+                f"@{field}:[VECTOR_RANGE {max_dist} $vector_{i}]=>{{$YIELD_DISTANCE_AS: distance_{i}}}"
            )

-        range_query = " | ".join(range_queries)
+        range_query = " AND ".join(range_queries)


This changes the multi-vector query from OR semantics (|) to AND semantics when combining vector range clauses. That’s a behavior change beyond “expose max_distance” and could be breaking for existing callers. If the AND behavior is intentional, it should be called out in the PR description/release notes (or consider preserving prior behavior via an option).

justin-cechmanek added 2 commits February 6, 2026 15:16

wip: adding max_distance via switch to use AND vector range query

b731542

adds max_distance as optional multivector query setting

45898df

Copilot AI review requested due to automatic review settings February 19, 2026 22:35

Copilot started reviewing on behalf of justin-cechmanek February 19, 2026 22:36 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

simplify max_distance validation

6d239f9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 19, 2026 23:00

Copilot started reviewing on behalf of justin-cechmanek February 19, 2026 23:01 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

adds docstring to Vector data class

3624f42

justin-cechmanek requested review from nkanu17 and vishal-bala February 19, 2026 23:16

nkanu17 approved these changes Feb 20, 2026

View reviewed changes

redisvl/query/aggregate.py Show resolved Hide resolved

tomjohnhall mentioned this pull request Feb 20, 2026

Handle missing multivector distance #479

Open

vishal-bala approved these changes Feb 20, 2026

View reviewed changes

redisvl/query/aggregate.py Outdated Show resolved Hide resolved

simplify max_distance validation

618c31d

Co-authored-by: Vishal Bala <vishal-bala@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 21, 2026 01:17

Copilot started reviewing on behalf of justin-cechmanek February 21, 2026 01:17 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

imports pydantic Field

f5b47a3

justin-cechmanek merged commit 61f0f41 into main Feb 21, 2026
47 checks passed

justin-cechmanek deleted the feat/RAAE-1098/expose-max-distance branch February 21, 2026 01:37

		if not isinstance(max_distance, (float, int)):
		raise ValueError("max_distance must be a value between 0.0 and 2.0")

Comments

Conversation

justin-cechmanek commented Feb 19, 2026

Uh oh!

jit-ci bot commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nkanu17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vishal-bala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants