mcp: bump sse timeout & add support for streamable http#11
Merged
garrett-raska merged 1 commit intomainfrom May 29, 2025
Merged
mcp: bump sse timeout & add support for streamable http#11garrett-raska merged 1 commit intomainfrom
garrett-raska merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR raises the SSE client timeout to 30 seconds for slower services and adds support for a new StreamableHTTPMCPEndpoint to communicate over HTTP streaming with the same timeout.
- Increase SSE timeout in
mcp_clientto 30 seconds. - Introduce
StreamableHTTPMCPEndpointclass and handle it inmcp_client. - Export
StreamableHTTPMCPEndpointin the package’s__init__.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/redpanda/agents/_mcp.py | Bumped SSE timeout, added StreamableHTTPMCPEndpoint and its branch in mcp_client. |
| src/redpanda/agents/init.py | Added StreamableHTTPMCPEndpoint to module exports. |
Comments suppressed due to low confidence (1)
src/redpanda/agents/_mcp.py:145
- There’s no test coverage for the new
StreamableHTTPMCPEndpointbranch inmcp_client. Consider adding unit tests to exercise this path.
elif isinstance(server, StreamableHTTPMCPEndpoint):
5 seconds is too low for slow services
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the SSE timeout to 30 seconds and adds support for streamable HTTP communication by introducing a new MCP endpoint.
- Bump SSE client timeout from the default to 30 seconds.
- Implement a new StreamableHTTPMCPEndpoint class using streamablehttp_client with a timedelta-based timeout.
- Update the module exports to include the new StreamableHTTPMCPEndpoint.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/redpanda/agents/_mcp.py | Added StreamableHTTPMCPEndpoint and updated mcp_client to support it. |
| src/redpanda/agents/init.py | Exported StreamableHTTPMCPEndpoint. |
garrett-raska
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 seconds is too low for slow services