Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@r-vasquez I've split the changes into 3 commits to help you with the review. |
kbatuigas
left a comment
kbatuigas
left a comment
There was a problem hiding this comment.
No blockers, but would appreciate a couple of clarifications!
There was a problem hiding this comment.
Am I correct in understanding that you can still use the --profile and --ignore-profile flags with rpk profile commands? Or do they end up being something like a no-op?
There was a problem hiding this comment.
They are mutually exclusive, and you'll get an error like
$ rpk topic create foo --profile foo --ignore-profile
Error: if any flags in the group [ignore-profile profile] are set none of the others can be; [ignore-profile profile] were all set
Usage:
rpk topic create [TOPICS...] [flags]
...
|
|
||
| * Cloud settings: Whether the `from_cloud` setting matches the broker URLs | ||
| * Auth reference: Whether the profile references a valid authentication | ||
| * Auth kind: Whether the authentication type is correctly configured |
There was a problem hiding this comment.
nit -- not sure if using "Auth" (instead of using the complete word) is a style decision or if it refers to something specific in this commands output
There was a problem hiding this comment.
Is the name of the "Check" which I chose to be shorter to display in the table form, for example
$ rpk profile validate
CHECK STATUS MESSAGE
Cloud Settings WARNING URLs look like Redpanda Cloud but from_cloud is set to false; run 'rpk profile set from_cloud=true'
Auth kind OK
Auth Token OK
| rpk profile validate | ||
| ---- | ||
|
|
||
| Validate a specific profile: |
There was a problem hiding this comment.
Would be awesome if we could get example output of when the command does identify issues
There was a problem hiding this comment.
$ rpk profile validate
CHECK STATUS MESSAGE
Cloud Settings WARNING URLs look like Redpanda Cloud but from_cloud is set to false; run 'rpk profile set from_cloud=true'
Auth kind OK
Auth Token OK
And a valid one
$ rpk profile validate
CHECK STATUS MESSAGE
Cloud Settings OK
Auth Reference OK
Auth kind OK
Auth Token OK
3 participants
Description
Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Updates the reference docs with the latest from rpk for 26.1.
Updated with redpanda-nightly:v0.0.0-20260221git47e07e7
Page previews
Checks