add TS 5.5 to test matrix

[EskiMojo14]

No description provided.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[netlify]

✅ Deploy Preview for redux-starter-kit-docs ready!

Name	Link
🔨 Latest commit	701b9ef
🔍 Latest deploy log	https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6696dde908ebe80008418019
😎 Deploy Preview	https://deploy-preview-4500--redux-starter-kit-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 701b9ef:

Sandbox	Source
@examples-query-react/basic	Configuration
@examples-query-react/advanced	Configuration
@examples-action-listener/counter	Configuration
rtk-esm-cra	Configuration

[github-actions]

size-limit report 📦

Path	Size

[aryaemami59]

redux-toolkit/packages/toolkit/src/tests/configureStore.test-d.ts

Lines 277 to 278 in a152b9e

	const counterReducer1: Reducer<number> = () => 0
	const counterReducer2: Reducer<number> = () => 0

- const counterReducer1: Reducer<number> = () => 0
- const counterReducer2: Reducer<number> = () => 0
+ const counterReducer1 = () => 0
+ const counterReducer2 = () => 0

This change seems to fix the issue related to TS 5.5.

[EskiMojo14]

redux-toolkit/packages/toolkit/src/tests/configureStore.test-d.ts

Lines 277 to 278 in a152b9e

	const counterReducer1: Reducer<number> = () => 0
	const counterReducer2: Reducer<number> = () => 0

- const counterReducer1: Reducer<number> = () => 0
- const counterReducer2: Reducer<number> = () => 0
+ const counterReducer1 = () => 0
+ const counterReducer2 = () => 0

This change seems to fix the issue related to TS 5.5.

that seems... bad?
it looks like the reverse mapping used by ReducersMapObject seems to have broken somehow

[aryaemami59]

it looks like the reverse mapping used by ReducersMapObject seems to have broken somehow

Yeah I'm not really sure why tbh, this also fixes it:

redux-toolkit/packages/toolkit/src/tests/configureStore.test-d.ts

Lines 277 to 278 in a152b9e

	const counterReducer1: Reducer<number> = () => 0
	const counterReducer2: Reducer<number> = () => 0

- const counterReducer1: Reducer<number> = () => 0
- const counterReducer2: Reducer<number> = () => 0
+ const counterReducer1: Reducer<number, UnknownAction> = () => 0
+ const counterReducer2: Reducer<number, UnknownAction> = () => 0

[EskiMojo14]

that makes no sense, UnknownAction is the default for that type parameter anyway 🤔
Reducer<number> and Reducer<number, UnknownAction> should be equivalent.

wtf typescript? 😅

[aryaemami59]

that makes no sense, UnknownAction is the default for that type parameter anyway 🤔
Reducer<number> and Reducer<number, UnknownAction> should be equivalent.

Yeah I was thinking the exact same thing, I tried to dig to see what exactly causes the issue but I kind of gave up. I think it might be because when we explicitly pass in generic type parameters to Reducer, the type for preloadedState does not get inferred. It just becomes the default State because TS can't do partial inference for generic type parameters. I could be very well wrong though.

Edit: My previous hunch is not correct, You're right. It has something to do with ReducersMapObject.

[EskiMojo14]

@aryaemami59 are you able to recreate it in the TS Playground? weirdly i can't seem to reproduce it there: https://tsplay.dev/N7kyEN

[Andarist]

TS playground repro: link, the change bisects to microsoft/TypeScript#57837

[Andarist]

Actual minimal repro: TS playground

Consider me nerd-sniped. I will be digging into it more tomorrow.

[aryaemami59]

This looks very interesting.

[Andarist]

microsoft/TypeScript#59232

[markerikson]

Where do we stand on this one?

[markerikson]

I think this is now a dupe of #4567 .