Skip to content

Catch all exceptions in health checks #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masenf wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

Catch all exceptions in health checks #6089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reflex/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def get_db_status() -> dict[str, bool]:
engine = get_engine()
with engine.connect() as connection:
connection.execute(sqlalchemy.text("SELECT 1"))
except sqlalchemy.exc.OperationalError:
except Exception:
status = False

return {"db": status}
Expand Down
4 changes: 1 addition & 3 deletions reflex/utils/prerequisites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,6 @@ async def get_redis_status() -> dict[str, bool | None]:
Returns:
The status of the Redis connection.
"""
from redis.exceptions import RedisError

try:
status = True
redis_client = get_redis()
Expand All @@ -442,7 +440,7 @@ async def get_redis_status() -> dict[str, bool | None]:
await ping_command
else:
status = None
except RedisError:
except Exception:
status = False

return {"redis": status}
Expand Down
Loading