Skip to content

OPS-1430: Add what are you interested in option in demo form#6459

Open
carlosabadia wants to merge 3 commits intomainfrom
carlos/update-demo-form-options
Open

OPS-1430: Add what are you interested in option in demo form#6459
carlosabadia wants to merge 3 commits intomainfrom
carlos/update-demo-form-options

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented May 5, 2026

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing carlos/update-demo-form-options (d0c7bdd) with main (d9b4a76)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@carlosabadia carlosabadia added the documentation Improvements or additions to documentation label May 5, 2026
@carlosabadia carlosabadia marked this pull request as ready for review May 5, 2026 16:35
@carlosabadia carlosabadia requested a review from a team as a code owner May 5, 2026 16:35
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 5, 2026

Greptile Summary

This PR adds a new "What are you interested in?" select field to the demo form (with options: AI builder, MCP, On-Prem, App Management) and consolidates it alongside the existing "How technical are you?" field into the responsive 2-column grid, creating a clean 2×2 layout on medium+ screens. The interested_in key is correctly registered in PostHog's _COMMON_KEYS so it is captured in the demo_request event.

  • demo_form.py: New required interested_in select field added; technical_level field moved into the md:grid-cols-2 grid (4 fields now, 2×2 on desktop).
  • posthog.py: "interested_in" added to _COMMON_KEYS, which is also used by the intro form tracker — this is harmless since the key is absent from intro form submissions and is simply filtered out.

Confidence Score: 4/5

Safe to merge — the changes are additive and self-contained, touching only the form layout and PostHog key allowlist.

The new field is wired up correctly end-to-end: it appears in the form, it is required, and its key is present in the PostHog allowlist. The only observation is a minor style inconsistency where one select_field call still passes required as a positional True rather than the keyword required=True used by every other call in the same block.

No files require special attention; the style inconsistency in demo_form.py is cosmetic only.

Important Files Changed

Filename Overview
packages/reflex-components-internal/src/reflex_components_internal/blocks/demo_form.py Adds "What are you interested in?" select field and moves "How technical are you?" into the 2-column responsive grid, creating a 2×2 layout on medium+ screens.
packages/reflex-components-internal/src/reflex_components_internal/blocks/telemetry/posthog.py Adds "interested_in" to _COMMON_KEYS so the new field is included in PostHog tracking for demo form submissions.

Sequence Diagram

sequenceDiagram
    participant User
    participant DemoForm
    participant DemoFormStateUI
    participant PostHog

    User->>DemoForm: Fill fields (name, email, company, interested_in, technical_level, …)
    User->>DemoForm: Submit
    DemoForm->>DemoFormStateUI: track_demo_form_posthog(form_data)
    DemoFormStateUI->>PostHog: track_demo_form_posthog_submission(form_data)
    Note over PostHog: Filter keys via _COMMON_KEYS<br/>(now includes "interested_in")
    PostHog-->>User: posthog.identify + posthog.capture("demo_request", props)
    DemoForm->>DemoForm: Close dialog (demo_form_open_cs = false)
Loading

Reviews (1): Last reviewed commit: "update word" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant