Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jan 24, 2026

This PR adds the following changes and is practically a generalized version of #3101:

  1. CMake is no more hardcoding make in the build step, but rather uses cmake --build. This allows to alternative build generators by passing them in the config_opts, e.g., self.build_system.config_opts = ['-G', 'Ninja'].
  2. The make_opts is deprecated in favor of the new more generic build_opts.
  3. builddir's default value is now "." instead of None and None is no more supported.

Closes #3378.
Closes #3465.

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (da2fbb3) to head (00a01d0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3614   +/-   ##
========================================
  Coverage    91.37%   91.38%           
========================================
  Files           62       62           
  Lines        13484    13488    +4     
========================================
+ Hits         12321    12326    +5     
+ Misses        1163     1162    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Ninja not allowed in cmake build Support additional CMake build system generators

1 participant