Add riscv64 as a target architecture#59
Open
lukaszsobala wants to merge 5 commits intorefresh-bio:masterfrom
Open
Add riscv64 as a target architecture#59lukaszsobala wants to merge 5 commits intorefresh-bio:masterfrom
lukaszsobala wants to merge 5 commits intorefresh-bio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for developing FAMSA!
Firstly I must say that I am not a software engineer, I am just using the LLM coding tools. I am proposing these changes as is and I will not be able to answer technical questions about the approach. What I can say is that the changes are enough to port FAMSA to riscv64 (
-march=rv64g). The program compiles (gmake PLATFORM=rv64g) and works.Some simplification of the nested loop in
refresh.mkis also proposed.The specific riscv64 device I possess has the architecture
rv64imafdvcsu, which also supports compressed and vector extensions (rv64gcv). It may be possible that they can make the program faster. I do not know which architecture target is most common forriscv64software. If superflouous, the targetrv64gcvcan be removed.