Skip to content

fix version #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliaksandrsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix version #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LangSwitcher/Sources/Localization/Strings_en.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ enum Strings_en {
// ── About Window ────────────────────────────────────────────
"about.windowTitle": "About LangSwitcher",
"about.appName": "LangSwitcher",
"about.version": "Version 1.0.0",
"about.version": "Version 1.1.0",
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the app version inside localized strings duplicates the source of truth (the bundle’s CFBundleShortVersionString / MARKETING_VERSION) and can easily drift again on the next release. Consider making this string a localized format/prefix (e.g., "Version %@") and composing it in the About UI using Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString").

Suggested change
"about.version": "Version 1.1.0",
"about.version": "Version %@",

Copilot uses AI. Check for mistakes.
"about.tagline": "Open-source keyboard layout text converter for macOS",
"about.howToUse": "How to use:",
"about.step1": "Select text typed in wrong layout",
Expand Down
2 changes: 1 addition & 1 deletion LangSwitcher/Sources/Localization/Strings_ru.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ enum Strings_ru {
// ── Окно «О программе» ──────────────────────────────────────
"about.windowTitle": "О программе LangSwitcher",
"about.appName": "LangSwitcher",
"about.version": "Версия 1.0.0",
"about.version": "Версия 1.1.0",
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the app version inside localized strings duplicates the source of truth (the bundle’s CFBundleShortVersionString / MARKETING_VERSION) and can easily drift again on the next release. Consider making this string a localized format/prefix (e.g., "Version %@" / "Версия %@") and composing it in the About UI using Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString").

Suggested change
"about.version": "Версия 1.1.0",
"about.version": "Версия %@",

Copilot uses AI. Check for mistakes.
"about.tagline": "Конвертер раскладки клавиатуры для macOS с открытым кодом",
"about.howToUse": "Как использовать:",
"about.step1": "Выделите текст, набранный не в той раскладке",
Expand Down
Loading