Fix compilation in 9.4 and 9.6 with updated network package#3
Open
alt-romes wants to merge 4 commits intoreinerp:masterfrom
Open
Fix compilation in 9.4 and 9.6 with updated network package#3alt-romes wants to merge 4 commits intoreinerp:masterfrom
alt-romes wants to merge 4 commits intoreinerp:masterfrom
Conversation
Author
|
It's unfortunate that the cbits are still calling a lot of deprecated functions. However, the other interactions with AppleScript worked. |
Previously we were using "show" in instances for String, Text, and Strict.Text. However, this causes failures in most values spliced in between quotes. Therefore, we no longer "show" the textual values and instead simply use them as is. If quotes around the string are desired it must be shown manually or added manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation, and is rebased on #2, including those commits