Open
Conversation
Previous behavior was to set the inverse of `has_many` objects as attributes. This can be problematic in the case of attempting to serialize attributes (think, infinite recursion). It is also different than how most other relationship are expected to behave (i.e. saving them in the `Association@cached_data`. This commit exposes `Association#cached_data` and has the `HasManyAssociation#fetch` attempt to save the inverse relationship in the `cached_data` if such a relationship/association is defined (most often through the `AssociationProxy`.
voltechs
added a commit
to TwilightCoders/her
that referenced
this pull request
Mar 31, 2026
Ref: remi#292 When fetching has_many associations, set the inverse parent through the association's cached_result rather than injecting it directly into the child's attributes hash. This prevents the parent object from appearing as a serializable attribute on child records.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behavior was to set the inverse of
has_manyobjects as attributes.This can be problematic in the case of attempting to serialize attributes
(think, infinite recursion). It is also different than how most other
relationship are expected to behave (i.e. saving them in the
Association@cached_data. This commit exposesAssociation#cached_dataandhas the
HasManyAssociation#fetchattempt to save the inverse relationship inthe
cached_dataif such a relationship/association is defined (most oftenthrough the
AssociationProxy.