Skip to content

Styler-ify Credo rules: FilterFilter, RejectReject, ExpensiveEmptyEnumCheck, and RaiseInsideRescue#14

Merged
JesseHerrick merged 2 commits intomainfrom
credo-rule-additions
May 6, 2026
Merged

Styler-ify Credo rules: FilterFilter, RejectReject, ExpensiveEmptyEnumCheck, and RaiseInsideRescue#14
JesseHerrick merged 2 commits intomainfrom
credo-rule-additions

Conversation

@JesseHerrick
Copy link
Copy Markdown
Member

@JesseHerrick JesseHerrick commented May 6, 2026

  • Refactor.FilterFilter: Enum.filter |> Enum.filter => single filter combined with &&
  • Refactor.RejectReject: Enum.reject |> Enum.reject => single reject combined with ||
  • Warning.ExpensiveEmptyEnumCheck: length(x) == 0 => x == []; Enum.count(x) == 0 => Enum.empty?(x)
  • Warning.RaiseInsideRescue: raise foo inside a rescue clause => reraise foo, __STACKTRACE__

Note

Medium Risk
Adds new AST rewrite rules that change emitted code for common patterns (pipes, empty checks, rescue re-raises) and adjusts directive alias-lifting behavior, which could affect formatting/output in edge cases.

Overview
Styler now enforces four additional Credo rules by rewriting code: it merges chained Enum.filter/2 and Enum.reject/2 pipes into a single call with a combined predicate, replaces expensive emptiness checks like length(x) == 0/Enum.count(x) == 0 with x == [] or Enum.empty?/1, and rewrites raise inside rescue clauses to reraise ..., __STACKTRACE__ to preserve stacktraces.

It also changes alias-lifting so require directives are no longer rewritten via aliases (avoiding invalid ordering where require Bar would appear before alias Foo.Bar), updates documentation to recommend disabling the newly covered Credo checks, and adds targeted tests for all new rewrite behaviors.

Reviewed by Cursor Bugbot for commit 0462740. Bugbot is set up for automated code reviews on this repo. Configure here.

- Refactor.FilterFilter: Enum.filter |> Enum.filter => single filter combined with &&
- Refactor.RejectReject: Enum.reject |> Enum.reject => single reject combined with ||
- Warning.ExpensiveEmptyEnumCheck: length(x) == 0 => x == []; Enum.count(x) == 0 => Enum.empty?(x)
- Warning.RaiseInsideRescue: raise foo inside a rescue clause => reraise foo, __STACKTRACE__
@JesseHerrick JesseHerrick merged commit fad8a2f into main May 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant