feat(benefits) - surface benefits x-jsf-presentation#1000
Open
gabrielseco wants to merge 6 commits intomainfrom
Open
feat(benefits) - surface benefits x-jsf-presentation#1000gabrielseco wants to merge 6 commits intomainfrom
gabrielseco wants to merge 6 commits intomainfrom
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't surfacing some benefits details in the Onboarding
The way we do as x-jsf-presentation is dynamic, we surface it for both contractor management and onboarding
We did some work to make correct the data on the BE for the partners and sandbox env
Note
Medium Risk
Extends the public
onboardingBag.metashape to include schema-provided presentation data, which may affect downstream consumers that assume a fixed meta structure. Also introduces new HTML rendering paths (sanitized) for benefits copy that should be validated against real backend payloads.Overview
Surfaces JSON schema-level
x-jsf-presentationmetadata through the headless form layer and exposes it ononboardingBag.meta.presentationfor both employee onboarding and contractor onboarding.Updates the example onboarding UI to render a new Benefits “About” card using the presentation
descriptionandurl(via sanitized HTML), and adds onboarding flow tests asserting presentation is present for the benefits step and absent for steps without it. Also exportssanitizeHtmlfrominternalsfor internal consumers.Reviewed by Cursor Bugbot for commit d095427. Bugbot is set up for automated code reviews on this repo. Configure here.