Skip to content

feat(benefits) - surface benefits x-jsf-presentation#1000

Open
gabrielseco wants to merge 6 commits intomainfrom
benefits-step-about
Open

feat(benefits) - surface benefits x-jsf-presentation#1000
gabrielseco wants to merge 6 commits intomainfrom
benefits-step-about

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 5, 2026

We weren't surfacing some benefits details in the Onboarding

The way we do as x-jsf-presentation is dynamic, we surface it for both contractor management and onboarding

We did some work to make correct the data on the BE for the partners and sandbox env

image

Note

Medium Risk
Extends the public onboardingBag.meta shape to include schema-provided presentation data, which may affect downstream consumers that assume a fixed meta structure. Also introduces new HTML rendering paths (sanitized) for benefits copy that should be validated against real backend payloads.

Overview
Surfaces JSON schema-level x-jsf-presentation metadata through the headless form layer and exposes it on onboardingBag.meta.presentation for both employee onboarding and contractor onboarding.

Updates the example onboarding UI to render a new Benefits “About” card using the presentation description and url (via sanitized HTML), and adds onboarding flow tests asserting presentation is present for the benefits step and absent for steps without it. Also exports sanitizeHtml from internals for internal consumers.

Reviewed by Cursor Bugbot for commit d095427. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 211.3 kB 211.12 kB +179 B (+0.1%) 🔴
Total (raw) 571.98 kB 570.92 kB +1.06 kB (+0.2%) 🔴
CSS (gzip) 20.75 kB 20.69 kB +61 B (+0.3%) 🔴
CSS (raw) 108.29 kB 107.95 kB +342 B (+0.3%) 🔴

Size Limits

  • ✅ Total gzipped: 211.3 kB / 250 kB (84.5%)
  • ✅ Total raw: 571.98 kB / 600 kB (95.3%)
  • ✅ CSS gzipped: 20.75 kB / 25 kB (83.0%)

Largest Files (Top 5)

  1. chunk-XG6ASTX5.js - 14 kB (0 B (0%))
  2. styles.css - 10.38 kB (+31 B (+0.3%))
  3. index.css - 10.38 kB (+30 B (+0.3%))
  4. index.js - 6.06 kB (+2 B (+0.0%))
  5. chunk-TNQKP2XT.js - 5.89 kB (0 B (0%))
View All Files (312 total)
File Size (gzip) Change
chunk-XG6ASTX5.js 14 kB 0 B (0%)
styles.css 10.38 kB +31 B (+0.3%)
index.css 10.38 kB +30 B (+0.3%)
index.js 6.06 kB +2 B (+0.0%)
chunk-TNQKP2XT.js 5.89 kB 0 B (0%)
chunk-KAHAW4HH.js 5.81 kB new
chunk-RZCU2MT3.js 5.23 kB 0 B (0%)
chunk-WUSKSXW2.js 4.62 kB 0 B (0%)
chunk-I66TFXX4.js 4.35 kB new
chunk-QYNWADPG.js 4.06 kB 0 B (0%)

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 90.02% 90.02% 0%
Statements 89.69% 89.69% 0%
Functions 87.68% 87.68% 0%
Branches 80.06% 80.06% 0%

Detailed Breakdown

Lines Coverage
  • Covered: 3673 / 4080
  • Coverage: 90.02%
  • Change: 0% (2 lines)
Statements Coverage
  • Covered: 3734 / 4163
  • Coverage: 89.69%
  • Change: 0% (2 statements)
Functions Coverage
  • Covered: 996 / 1136
  • Coverage: 87.68%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2272 / 2838
  • Coverage: 80.06%
  • Change: 0% (0 branches)

✅ Coverage check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-bnkzdj8ko-remotecom.vercel.app
Latest Commit:d095427
Inspect:View deployment

Deployed with vercel-action

@gabrielseco gabrielseco self-assigned this May 8, 2026
@gabrielseco gabrielseco requested a review from jordividaller May 8, 2026 15:21
@gabrielseco gabrielseco marked this pull request as ready for review May 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant