-
Notifications
You must be signed in to change notification settings - Fork 0
feat(contractor-onboarding): add custom pricing plan cards with component override support #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…plan before contract details
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (267 total)
✅ Bundle size check passed |
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit 1ee4330. |
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 1ee4330. |
|
npm warn exec The following package was not found and will be installed: tsx@4.21.0 📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
…re contract details
| title: 'Payment terms', | ||
| description: 'Choose the plan that best fits your needs.', | ||
| type: 'string', | ||
| oneOf: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had an endpoint, are you missing some data from it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, we're still using the endpoint
I'll check and see if I a missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have the endpoint but the endpoint doesn't bring us the text data that I added it
Should we add it on the endpoint?
const: 'urn:remotecom:resource:product:contractor:plus:monthly',
title: 'Contractor Management Plus',
description: 'Engage and pay contractors with indemnity coverage',
'x-jsf-presentation': {
meta: {
features: [
'Contract between you and contractor',
'Access to all Contractor Management features',
'$100K indemnity coverage for penalties',
'4X monetary coverage than our competitors in case of penalties',
],
},
},I added description and meta.features to show it on the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can add it to the endpoint, that's best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but we might have to hardcode the meta.features part as far as I know, I am modifying the current {{SANDBOX_URL}}/v1/contractors/employments/{{employment_id}}/contractor-subscriptions to drop the employment_id and only return the contractor products
EDIT: Wrong account this is Hamza
…atures unavailable
…contractor subscriptions
This PR introduces a custom pricing plan card component for the contractor onboarding flow, enabling better visualization and selection of subscription plans.