Refactor to use SwapChainDesc. Introduce tweaks to present() for Vulkan and D3D12. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Wiseguy
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two key changes suggested by @Mr-Wiseguy.
As both of these changes rely on the existence of present wait to behave as intended, and to try to simplify the introduction of these changes, they're only activated if present wait is explicitly enabled for the swap chain.
I'm not aware of what possibilities we have here to introduce further changes in Metal, so the Metal changes should only just be to take the new input that is now a Desc structure similar to the rest of the code used, as the function was starting to grow pretty big.