This repository was archived by the owner on Nov 12, 2024. It is now read-only.
Disable automatic culling #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work, this PRs short and easy to review! Promoting to |
|
unbooping: approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #410 we're using shader uniform to apply camera instead of calculating the transformed vertices on CPU, the final vertices we calculate in
drawRaware world-space instead of screen-space due to this change, making the bound checking pointless if any camera transformation is involved. The direct effect is objects outside of [0, 0] - [width, height] were not rendered despite being in camera.Should fix this