Skip to content

feat: remove MdxRoute and react-router-mdx dependency#1247

Open
jderochervlk wants to merge 1 commit intomasterfrom
vlk/combined-remove-mdx-route
Open

feat: remove MdxRoute and react-router-mdx dependency#1247
jderochervlk wants to merge 1 commit intomasterfrom
vlk/combined-remove-mdx-route

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented Apr 12, 2026

Note

These changes were done with the assistance of AI

  • Delete MdxRoute.res/.resi (all pages now handled by split routes)
  • Remove react-router-mdx from package.json and delete yarn patch
  • Remove react-router-mdx externals from Mdx.res
  • Remove mdxRoutes binding from ReactRouter.res
  • Remove react-router-mdx init from react-router.config.mjs and generate-route-types.mjs
  • Add DocsManualRoute for /docs/manual pages with sidebar and TOC
  • Add DocsReactRoute for /docs/react pages with sidebar and TOC
  • Add SyntaxLookupDetailRoute for /syntax-lookup/* detail pages
  • Add SidebarHelpers module for shared sidebar nav/category generation
  • Add MdxFile.loadAllAttributes to replace react-router-mdx loadAllMdx
  • Migrate BlogRoute to use MdxFile.loadAllAttributes
  • Migrate SyntaxLookupRoute to use MdxFile.loadAllAttributes
  • Migrate CommunityRoute to use SidebarHelpers and MdxFile.loadAllAttributes
  • Fix Mdx.sortSection comparator to handle all cases explicitly
  • Update routes.res to register all split routes and remove mdxRoutes

Combines PRs #1221, #1222, #1225, #1227

- Delete MdxRoute.res/.resi (all pages now handled by split routes)
- Remove react-router-mdx from package.json and delete yarn patch
- Remove react-router-mdx externals from Mdx.res
- Remove mdxRoutes binding from ReactRouter.res
- Remove react-router-mdx init from react-router.config.mjs and generate-route-types.mjs
- Add DocsManualRoute for /docs/manual pages with sidebar and TOC
- Add DocsReactRoute for /docs/react pages with sidebar and TOC
- Add SyntaxLookupDetailRoute for /syntax-lookup/* detail pages
- Add SidebarHelpers module for shared sidebar nav/category generation
- Add MdxFile.loadAllAttributes to replace react-router-mdx loadAllMdx
- Migrate BlogRoute to use MdxFile.loadAllAttributes
- Migrate SyntaxLookupRoute to use MdxFile.loadAllAttributes
- Migrate CommunityRoute to use SidebarHelpers and MdxFile.loadAllAttributes
- Fix Mdx.sortSection comparator to handle all cases explicitly
- Update routes.res to register all split routes and remove mdxRoutes

Combines PRs #1221, #1222, #1225, #1227
@github-actions
Copy link
Copy Markdown

Cloudflare deployment

Deployement ID: 22c9cbd5-7511-4348-9bf0-e797695298f2
Deployment Environment: preview

⛅️ wrangler 4.63.0 (update available 4.81.1)
─────────────────────────────────────────────
✨ Compiled Worker successfully
Uploading... (7222/7846)
Uploading... (7430/7846)
Uploading... (7638/7846)
Uploading... (7846/7846)
✨ Success! Uploaded 624 files (7222 already uploaded) (5.17 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://22c9cbd5.rescript-lang.pages.dev
✨ Deployment alias URL: https://vlk-combined-remove-mdx-rout.rescript-lang.pages.dev

@jderochervlk jderochervlk marked this pull request as ready for review April 12, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant