Bump Rust edition to 2024 and MSRV to 1.85 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important, we need to release these changes with a new minor release.
tillrohrmann
force-pushed
the
bump-edition
branch
from
477e73b to
50e0dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to pull in some dependencies which have bumped their edition to 2024 with a patch release. Due to this aspect, our CI builds are failing (https://github.com/restatedev/sdk-rust/actions/runs/20296738957/job/58292099512). A very simple solution would have been to pin
hometov0.5.11. However, upgrading to edition 2024 ourselves which is out for roughly a year and bumping the MSRV to 1.85 seemed like the more long term way to go.Important, we need to release these changes with a new minor release and add a release note that our Rust SDK now requires the edition 2024.