Open
Conversation
vanthome
requested changes
Mar 24, 2026
| repeated string totp_session_tokens = 29; /// TOTP Login session tokens | ||
| repeated string password_hash_history = 30; // List of historical password hashes | ||
| repeated string totp_recovery_codes = 31; // List of TOTP recovery codes | ||
| optional string impoersonated_by = 32; // ID of the impersonator |
Member
There was a problem hiding this comment.
Wrong place for this, this should go in the token object not the LoginResponse. Or do we need it really here as well?
Author
There was a problem hiding this comment.
Wrong place for this, this should go in the token object not the LoginResponse. Or do we need it really here as well?
No idea, this is how Arun suggested to handle it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.