Open
Conversation
Splines
requested changes
Apr 12, 2024
Collaborator
|
Note that if #41 is merged beforehand, we will have a small merge conflict in |
Collaborator
|
Ok, so this looks good to me now! As this is modifying |
commit e8d3467 Author: Splines <37160523+Splines@users.noreply.github.com> Date: Fri Sep 6 19:02:36 2024 +0200 Implement new `wiz.res()` API (#41) * Remove plum as dependency * Implement new `wiz.res()` API (see #33) * Fix errors in error messages * Use consistent comment format in error messages * Add docstrings to `wiz.res()` * Add missing `int` type for uncertainties * Add PrintableResult to res() method signature * Rename `uncert` to `uncerts` (plural) commit cc6bf5b Author: paul019 <39464035+paul019@users.noreply.github.com> Date: Sat Apr 27 20:25:54 2024 +0200 Improve wording: use `uncertainty` instead of `error` (#43) * Remove spaces in units * Detect percent as unit in console stringifier * Replace error by uncert * Undo unwanted changes * Replace error by uncertainty in various places commit 62c34a5 Author: Splines <37160523+Splines@users.noreply.github.com> Date: Sat Apr 27 19:45:34 2024 +0200 Add missing `site.baseurl` to relative links (#52) commit f5e0007 Author: Splines <37160523+Splines@users.noreply.github.com> Date: Sat Apr 27 19:45:19 2024 +0200 Truncate Readme & refer to documentation (#51) * Truncate Readme & refer to documentation * Remove GitHub-flavored markdown Otherwise, it won't be rendered correctly on PyPI. * Make Readme image clickable (points to docs) commit 7af242c Author: Splines <37160523+Splines@users.noreply.github.com> Date: Wed Apr 24 17:56:11 2024 +0200 Add first version of docs (#37) * Init _Just the docs_ basic structure * Add Jupyter-related items to TODO * Add GitHub pages docs workflow * Add 404 page * Add landing page of documentation * Add LaTeX rendered output * Add quickstart & backbone for other pages * Add `export()` & siunitx troubleshooting * Add docs for `wiz.res()` * Add `wiz.res()` tip for multiple occurrences * Add config options & siunitx tips * Improve Jupyter section & add "Is this really for me?" * Add about page * Add table of contents (TOC) back to about page * Add docs build workflow for PRs * Specify correct cwd for docs workflow * Fix remaining docs workflow errors * Add tip for how to suppress output in JupyterNotebook. This fixes #44. commit 63f2a6b Author: Splines <37160523+Splines@users.noreply.github.com> Date: Mon Apr 22 23:31:50 2024 +0200 Update GitHub URLs to point to new repo location (#47)
This reverts commit 1f775ff.
Splines
requested changes
Sep 11, 2024
Collaborator
Splines
left a comment
Splines
left a comment
There was a problem hiding this comment.
Please don't squash commits from other branches as this messes with Git (e.g. on GitHub we suddenly saw 32 files changes instead of just 2). You probably wanted to use a normal merge commit for that. I've just reverted your changes and then merged main into this branch.
But indeed use squash commits when merging a feature branch into main, as we don't want all individual commits there.
| stat: Union[float, int, str, Decimal, None] = None, | ||
| sigfigs: Union[int, None] = None, | ||
| decimal_places: Union[int, None] = None, | ||
| print: Union[bool, None] = None, # pylint: disable=redefined-builtin |
Collaborator
There was a problem hiding this comment.
Instead of just disabling this error message, shouldn't we rename print to something different to avoid overriding the internal print method accidentally? E.g. use should_print.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34