Abort image upload when signed-IDs fetch fails#72
Open
zew-rgn wants to merge 1 commit into
Open
Conversation
Previously fetchCurrentSignedIds silently returned [] on any failure (timeout, network, HTTP error, parse error). On slow sites, this caused the upload to PUT images: [newBase64] with no existing signed IDs. The backend treats has_many_attached assignment as a full replacement and purged every existing attachment. Adds fetchCurrentSignedIdsStrict + ImageFetchException. The upload call-site now aborts with a user-facing error instead of proceeding with an empty list. Mirrors the fix in ATT-FE-Tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchCurrentSignedIdssilently returned[]on any failure (timeout, network, HTTP error, parse error). On slow sites this caused the upload to PUTimages: [newBase64]with no existing signed IDs. The backend treatshas_many_attached :imagesassignment as a full replacement and purged every existing attachment.fetchCurrentSignedIdsStrict+ImageFetchException. The upload call-site now aborts with a user-facing error instead of proceeding with an empty list. Mirrors the parallel fix in ATT-FE-Tool.Test plan
🤖 Generated with Claude Code