Skip to content

feat(critters): improve animation parsing and font preloading#104

Open
riceharvest wants to merge 2 commits intomainfrom
feat/critters-improvements
Open

feat(critters): improve animation parsing and font preloading#104
riceharvest wants to merge 2 commits intomainfrom
feat/critters-improvements

Conversation

@riceharvest
Copy link
Copy Markdown
Owner

This PR addresses issue #26 by improving the critters package:

  • Improve animation declaration parsing in runtime.js to extract specific names rather than using lazy matching.
  • Enhance font parsing to generate multiple type-specific preloads (e.g., font/woff2).
  • Remove unnecessary DOM properties not required for css-select integration.

All tests pass.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

…loads\n\n- Adds explicit type attribute using format when provided\n- Infers MIME type from file extension when format missing (woff2, woff, ttf, otf, eot, svg)\n- Ensures multiple font formats each get appropriate type for better browser handling\n\nCloses #26
…r css-select\n\nRemoves id, className, getAttributeNode from ElementExtensions; contentType, createTextNode from DocumentExtensions. These are not used by the package and are unnecessary for css-select integration.\n\nCloses #26
@riceharvest riceharvest force-pushed the feat/critters-improvements branch from 3221305 to bd6a4bc Compare March 30, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant