Add ValidationErrorsCount control by Copilot · Pull Request #1969 · riganti/dotvvm

Copilot · 2025-12-05T15:57:17Z

New control similar to ValidationSummary that displays only the count of validation errors in the current Validation.Target.

Changes

ValidationErrorsCount.cs - New control with:
- IncludeErrorsFromChildren (default: true) - count errors from nested objects
- IncludeErrorsFromTarget (default: true) - count errors from target itself
- InvalidCssClass - CSS class applied when errors exist
- WrapperTagName (default: span) - customizable wrapper tag
validation.ts - Added dotvvm-validationErrorsCount Knockout binding handler

Usage

<!-- Basic -->
<dot:ValidationErrorsCount />

<!-- With target and invalid class -->
<dot:ValidationErrorsCount Validation.Target={value: Person} InvalidCssClass="has-errors" />

<!-- Custom wrapper -->
<dot:ValidationErrorsCount WrapperTagName="div" />

<!-- Only target errors, no children -->
<dot:ValidationErrorsCount IncludeErrorsFromChildren="false" />

Note: IncludeErrorsFromChildren defaults to true (unlike ValidationSummary which defaults to false) per the issue requirements.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

0t3vsblobprodcus362.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
1p7vsblobprodcus324.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
1s1vsblobprodcus386.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/Tests/DotVVM.Samples.Tests.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep orking/emptyFakeDotnetRoot working/emptyFakeDotnetRoot gCompilationTests.cs rgo/bin/grep (dns block)
4m6vsblobprodcus384.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
7devsblobprodcus323.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/00DA3BA51762B14D47D4C9F6E8A232CB/missingpackages_workingdir --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force -l testoutputs/ValidationErrorsCountTests.ValidationErrorsCount_WithValidationDisabled.html sts.cs rep (dns block)
cflvsblobprodcus383.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
k4kvsblobprodcus344.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
m6xvsblobprodcus342.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
pdfvsblobprodcus380.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
pe3vsblobprodcus354.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)
yttvsblobprodcus357.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>ValidationErrorsCount control</issue_title>
<issue_description>I need a control with a logic similar to ValidationSummary, but which would print only the count of validation errors in the current Validation.Target.
By default, it should include errors from the target and its children.
It should also have the InvalidCssClass property that would be applied on the element (specified in WrapperTagName - span by default) when there is at least one error.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes ValidationErrorsCount control #1968

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Create ValidationErrorsCount.cs control that displays validation error count - Support for IncludeErrorsFromChildren and IncludeErrorsFromTarget properties - Support for InvalidCssClass property to apply CSS class when errors exist - Support for WrapperTagName property (default: span) - Add JavaScript binding handler in validation.ts - Add unit tests for the new control Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>

- Add initial execution of updateErrorCount in JS to show count immediately - Add documentation clarifying IncludeErrorsFromChildren default differs from ValidationSummary Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

exyi

I'd also remove some of the useless doccomments which just read the name, it's a waste of user time (or tokens)

tomasherceg · 2026-02-15T20:45:07Z

I removed some XML comments, but kept those on DotVVM properties as we use them to generate documentation.
Also, I renamed the FormatErrorCount to FormatErrorsCount so we are at least consistent with the name of the control ValidationErrorsCount.

Initial plan

ce876ff

Copilot AI assigned Copilot and tomasherceg Dec 5, 2025

Copilot started work on behalf of tomasherceg December 5, 2025 15:57 View session

Copilot AI and others added 2 commits December 5, 2025 16:07

Address code review feedback

65c7dc7

- Add initial execution of updateErrorCount in JS to show count immediately - Add documentation clarifying IncludeErrorsFromChildren default differs from ValidationSummary Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add validation errors count control~~ Add ValidationErrorsCount control Dec 5, 2025

Copilot AI requested a review from tomasherceg December 5, 2025 16:16

Copilot finished work on behalf of tomasherceg December 5, 2025 16:16

tomasherceg added 2 commits January 22, 2026 15:24

Manual fixes in Copilot code

3433bdf

Added UI test

b36f58f

github-code-quality Bot found potential problems Feb 15, 2026

View reviewed changes

Comment thread src/Tests/ControlTests/ValidationErrorsCountTests.cs Fixed

tomasherceg and others added 2 commits February 15, 2026 11:46

Fixed config serialization test output

cbfed3a

Potential fix for pull request finding 'Missed 'readonly' opportunity'

39581a4

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

tomasherceg marked this pull request as ready for review February 15, 2026 14:25

exyi reviewed Feb 15, 2026

View reviewed changes

Comment thread src/Framework/Framework/Resources/Scripts/validation/validation.ts Outdated

exyi reviewed Feb 15, 2026

View reviewed changes

Removed comments, property rename

fc9d0d7

exyi approved these changes Mar 13, 2026

View reviewed changes

tomasherceg merged commit 934d138 into main Mar 13, 2026
22 of 23 checks passed

tomasherceg deleted the copilot/add-validation-errors-count-control branch March 13, 2026 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ValidationErrorsCount control#1969

Add ValidationErrorsCount control#1969
tomasherceg merged 8 commits intomainfrom
copilot/add-validation-errors-count-control

Copilot AI commented Dec 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

exyi left a comment

Uh oh!

tomasherceg commented Feb 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

I tried to connect to the following addresses, but was blocked by firewall rules:

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Uh oh!

exyi left a comment

Choose a reason for hiding this comment

Uh oh!

tomasherceg commented Feb 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 5, 2025 •

edited

Loading