Expose TestSchemaOpts.DisableReuse for test schema creation#1195
Open
Expose TestSchemaOpts.DisableReuse for test schema creation#1195
TestSchemaOpts.DisableReuse for test schema creation#1195Conversation
The `riverdbtest.TestSchema` function has had an internal `disableReuse` option for quite some time that prevents the test schema from being checked back in at the end of a test case. This is useful in cases where a schema might be modified and not suitable for pick up by a subsequent test. I was just testing some schema-related changes in Pro and found that it would be somewhat useful to be able to use this option from that package. We can also create our own test schemas from scratch over there, but `riverdbtest.TestSchema` has a number of niceties like being able to clean up test schemas even in the event of a panic and where cleanup hooks aren't run. I don't think there's any particularly harmful effect in exposing `DisableReuse` (except that it might encourage more of its use), so it's probably okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
riverdbtest.TestSchemafunction has had an internaldisableReuseoption for quite some time that prevents the test schema from being
checked back in at the end of a test case. This is useful in cases where
a schema might be modified and not suitable for pick up by a subsequent
test.
I was just testing some schema-related changes in Pro and found that it
would be somewhat useful to be able to use this option from that
package. We can also create our own test schemas from scratch over
there, but
riverdbtest.TestSchemahas a number of niceties like beingable to clean up test schemas even in the event of a panic and where
cleanup hooks aren't run.
I don't think there's any particularly harmful effect in exposing
DisableReuse(except that it might encourage more of its use), so it'sprobably okay.