Push maintenance leader startup logic down into maintenance package#1196
Open
Push maintenance leader startup logic down into maintenance package#1196
Conversation
This one's a quick follow up to #1184. Unfortunately in order to cover all the edge cases that Codex found during review we ended up with fairly complex start logic for the queue maintainer because it needs to have a separate goroutine, do a lot of context checking, and track its current leadership "epoch" to make sure that an older start attempt doesn't affect the start attempt booted off by a newer leadership signal. This had left an unfortunate amount of code in `client.go`. Here, break this all out into its own file in `internal/maintenance/`. This lets us streamline `Client` back to a nicer point.
brandur
force-pushed
the
brandur-push-maintainer-logic
branch
from
5326f39 to
4d86b90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one's a quick follow up to #1184. Unfortunately in order to cover
all the edge cases that Codex found during review we ended up with
fairly complex start logic for the queue maintainer because it needs to
have a separate goroutine, do a lot of context checking, and track its
current leadership "epoch" to make sure that an older start attempt
doesn't affect the start attempt booted off by a newer leadership
signal. This had left an unfortunate amount of code in
client.go.Here, break this all out into its own file in
internal/maintenance/.This lets us streamline
Clientback to a nicer point.