Merged
Conversation
This was referenced Apr 12, 2026
Contributor
Author
PR Review: fix(epoxy): use vbareBug: Double-deserialize in get_local.rsIn Fix: return the already-deserialized value directly: cache_value: cache_value.value.is_some().then_some(cache_value)Issue: Modifying envoy-protocol/v1.barePer CLAUDE.md: Never modify an existing published .bare protocol version. Removing Positives
The double-deserialize bug and v1.bare modification are the two items to address before merging. |
NathanFlurry
approved these changes
Apr 13, 2026
f94f435 to
896a1bb
Compare
9a8e0a8 to
143127a
Compare
Contributor
Author
Merge activity
|
143127a to
e2fb502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes RVT-6176